Skip to content

repository層のテストを消す#679

Merged
ras0q merged 1 commit into
mainfrom
remove/sql-mock-test
Jun 18, 2024
Merged

repository層のテストを消す#679
ras0q merged 1 commit into
mainfrom
remove/sql-mock-test

Conversation

@ras0q

@ras0q ras0q commented Jun 17, 2024

Copy link
Copy Markdown
Contributor

ORMを生SQLに書き替えてモックしており保守性が低いのと現状のintegration_tests/repositoryと目的が被っているので消したいです

@codecov

codecov Bot commented Jun 17, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.79%. Comparing base (e961e64) to head (0e1e884).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #679       +/-   ##
===========================================
- Coverage   61.34%   32.79%   -28.55%     
===========================================
  Files          54       54               
  Lines        4312     4312               
===========================================
- Hits         2645     1414     -1231     
- Misses       1606     2866     +1260     
+ Partials       61       32       -29     
Flag Coverage Δ
integration 32.79% <ø> (-28.55%) ⬇️
unit 32.79% <ø> (-28.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@H1rono H1rono left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iiyp

@ras0q
ras0q merged commit b12e3c6 into main Jun 18, 2024
@ras0q
ras0q deleted the remove/sql-mock-test branch June 18, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants