Skip to content

✨ allow x.com (and fix validation)#684

Merged
ras0q merged 4 commits into
mainfrom
fix/account-url-parse
Jun 18, 2024
Merged

✨ allow x.com (and fix validation)#684
ras0q merged 4 commits into
mainfrom
fix/account-url-parse

Conversation

@ras0q

@ras0q ras0q commented Jun 18, 2024

Copy link
Copy Markdown
Contributor

close #673

@ras0q
ras0q requested review from Pugma and mehm8128 June 18, 2024 09:09
Comment thread domain/user.go Fixed
Comment thread domain/user.go Fixed
Comment thread domain/user.go Fixed
@codecov

codecov Bot commented Jun 18, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 32.77%. Comparing base (0ad2c67) to head (a4a50f7).

Files Patch % Lines
domain/user.go 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #684      +/-   ##
==========================================
- Coverage   32.79%   32.77%   -0.02%     
==========================================
  Files          54       54              
  Lines        4312     4314       +2     
==========================================
  Hits         1414     1414              
- Misses       2866     2868       +2     
  Partials       32       32              
Flag Coverage Δ
integration 32.77% <0.00%> (-0.02%) ⬇️
unit 32.77% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread domain/user.go Fixed

@Pugma Pugma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!
okだとおもいます

@ras0q
ras0q merged commit 4556ac6 into main Jun 18, 2024
@ras0q
ras0q deleted the fix/account-url-parse branch June 18, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x.comのvalidation

3 participants