chore(promote): develop → main — fr-gate promotion-PR transparency - #95
Merged
Conversation
Without this, the staging->prod hop gates the PREVIOUS promotion PRs themselves: a release-train/to-staging merge is that PR's merge_commit_sha, so Pass 1 pulls e.g. averaging-service#211 / frontend-app#709 into the checked set, where they sit at 'FR on staging' forever (nobody FRs plumbing) and block the prod promotion. Worse, commits/pulls lists the promotion PR for every commit it carried, so Pass 2 could attribute a direct push to the promotion PR and launder it into 'covered'. Fix: filter head release-train/* out of attribution in both passes. The promotion merge neither vouches for its range nor appears as a gated item; its cargo attributes individually (feature merges in Pass 1, squash commits in Pass 2). A commit whose only merged PR is a promotion PR is a direct push that rode the train -- it stays unattributed and fails closed (D27-L1). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…arency fix(fr-gate): release-train promotion PRs are transparent plumbing
LukasWodka
added a commit
that referenced
this pull request
Jul 28, 2026
A push routinely carries commits that already shipped further down the pipeline: a staging->develop back-merge re-pushes Prod PRs to develop, and a develop==main fast-forward does the same. advance-deploy-env blindly set every PR in the push to the branch's column, un-shipping those cards (seen live: .github #87/#88/#89/#92 stranded at On dev after yesterday's ff, #95 demoted from Prod today; engine#540's back-merge would demote its whole staging history next). Now the per-PR query also reads the current Status and the update is skipped unless the target rank is strictly higher. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the fr-gate fix from #94 to
main(callers referencefr-gate.yml@main, so the fix only takes effect here). Merge-commit per the promotion-hop rule.🤖 Generated with Claude Code
Note
Medium Risk
Changes promotion gate attribution logic for main/staging merges; incorrect filtering could block valid promotions or miss unattributed commits.
Overview
FR gate commit→PR discovery now ignores merged PRs whose head branch is
release-train/*. Those promotion PRs are documented as train plumbing: they are not gated items, do not vouch for their merge range in Pass 1, and are stripped from Pass 2 attribution so the gate evaluates the cargo feature PRs instead.Pass 1 only counts a merge commit as vouching when the matched PR is not a release-train head. Pass 2 applies the same filter on
commits/{sha}/pulls; commits attributed only to a promotion PR stay unattributed (direct push on the train).Reviewed by Cursor Bugbot for commit 79f3293. Bugbot is set up for automated code reviews on this repo. Configure here.