fix(delete): copy fixes — reclaim hint + launcher-neutral preview#381
Merged
Conversation
The hint suggested `docker images ghcr.io/tracebloc/* --format …` — an unquoted positional glob. zsh (the macOS default) aborts on the unmatched glob before docker even runs, and the positional form doesn't apply the reference pattern the way PruneImages does. Use the same quoted --filter=reference form nodeboot uses for the real reclaim. Bugbot finding on the release PR (#377), thread already resolved there — this fixes the underlying copy. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a29bd5a. Configure here.
The preview said it removes "the tb CLI", but not every install has the
tb alias. Name the artifact the way the teardown result line already
does ("Removed the tracebloc CLI from this machine.") — accurate on
every install, no launcher resolution needed for descriptive copy.
Bugbot finding on the release PR (#377), round 3.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
LukasWodka
changed the title
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e2682d5. Configure here.
saadqbal
approved these changes
Jul 21, 2026
Collaborator
|
/fr-pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The image-reclaim failure hint suggested
docker rmi $(docker images ghcr.io/tracebloc/* --format …)— an unquoted positional glob. zsh (macOS default) aborts on the unmatched glob before docker runs, and the positional form doesn't apply the reference pattern the wayPruneImagesdoes. The hint now uses the same quoted--filter=reference='ghcr.io/tracebloc/*'form nodeboot uses for the real reclaim.Fixes the Bugbot finding from the release PR #377 re-scan (thread there already resolved; this fixes the underlying copy). One line + not release-blocking — fine to ride either this release or the next.
Related
Ref #377.
Type of change
Test plan
go build ./...,go test ./internal/cli/ -count=1,bash scripts/check-style.sh— all cleannodeboot.go's reclaim listing (--filter=reference="ghcr.io/tracebloc/*")Checklist
go build ./...,go vet, and the Lint job's checks pass locallybash scripts/check-style.shpasses🤖 Generated with Claude Code
Note
Low Risk
User-facing strings only in the delete/offboard path; no behavior or credential logic changes.
Overview
Offboard copy is tightened in two user-facing places.
When image reclaim fails during delete, the suggested manual cleanup command now uses
docker images --filter=reference='ghcr.io/tracebloc/*'instead of a positionalghcr.io/tracebloc/*glob. That matches howPruneImageslists images and avoids zsh aborting on an unmatched glob before Docker runs.The pre-confirm offboard preview refers to the tracebloc CLI instead of the tb CLI, so the wording stays accurate when the
tbalias is not installed.Reviewed by Cursor Bugbot for commit e2682d5. Bugbot is set up for automated code reviews on this repo. Configure here.