release-train: develop -> staging - #458
Merged
Merged
Conversation
…backend#1404) — baseline retired (#457) * sec(gitleaks): add commit-independent allowlist config (backend#1404) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * sec(gitleaks): retire the commit-pinned baseline (backend#1404) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * sec(ci): drop the gitleaks-baseline input (backend#1404) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
bugbot run |
tracebloc-release-train
Bot
added
gate-nudge
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Gitleaks parses the allowlist `condition` field case-sensitively and only recognizes uppercase `AND`/`OR`. The lowercase `"and"` was silently treated as the default `OR`, so the allowlist matched on targetRules OR paths OR regexes instead of requiring all criteria — over-matching and potentially suppressing real findings. Corrected to `AND`. Bugbot finding from backend#1404. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7289b4b. Configure here.
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7289b4b. Configure here.
tracebloc-release-train
Bot
added
gate-nudge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated promotion by the release train (RFC-0008 D14). Head is the train-managed
release-train/to-stagingbranch (a mirror ofdevelop), so it never collides with a human PR. Merged only when the fr-gate is green.Note
Low Risk
CI and secret-scan configuration only; no runtime or auth behavior changes.
Overview
Gitleaks is switched from a committed baseline file to repo-local
.gitleaks.tomlallowlists.The code-quality workflow no longer passes
gitleaks-baseline: .gitleaks-baseline.json, and.gitleaks-baseline.jsonis removed. A new.gitleaks.tomlextends the default rules and allowlists the same false positive: a syntheticIdempotencyKeystring in*_test.gofiles matchingnightly-claims-*, which previously lived as the single baseline entry forinternal/submit/submit_test.go.Reviewed by Cursor Bugbot for commit 7289b4b. Bugbot is set up for automated code reviews on this repo. Configure here.