release-train: staging -> main - #484
Merged
Merged
Conversation
…backend#1606) (#482) * chore(devex): install a make check pre-push hook via make setup (backend#1606) Step 4 of backend#1606, fanned out to cli. `make setup` now installs a git pre-push hook that runs `make check`, factored into a standalone, independently runnable `install-hooks` target. Mirrors the merged reference e2e-test-agent#46. Honest by construction: the hook catches forgetting, not defiance (`git push --no-verify` always skips it); it refuses to clobber a foreign pre-push hook; and it resolves the hooks dir via `git rev-parse --git-path hooks`, so it is worktree/submodule-safe. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * chore(devex): install-hooks comment — 'rerun make setup', not 'venv' (backend#1606) The copied block said 'need not rebuild the (minutes-long) venv', which is false for cli (Go) and client (tool-check only) and loose elsewhere. Generalise to 'need not rerun the full make setup' — true in every repo. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(devex): clear git's hook env in the pre-push hook so `make check` survives worktrees (backend#1606) Bugbot (Medium) on cli#482: git exports GIT_DIR/GIT_WORK_TREE/etc into hook processes. `make check` runs `go test`, whose buildvcs probe shells out to git under that env and fails with "exit status 128" in a linked worktree/submodule — so a green tree could still block every push, in exactly the worktree case the install claims to be safe in. Fix: the generated hook now `unset`s the git hook-env vars before `exec make check`, so the checks run as if invoked from the shell (git rediscovers the repo from the CWD). Harmless in normal clones; only affects the broken-in-worktree case. cli is the only Go repo, but the hook content is uniform across the fleet, so this same change lands in every install-hooks target. Verified: Makefile parses; generated hook is valid `sh -n`; the unset clears GIT_DIR/GIT_WORK_TREE for the child. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(devex): fail install-hooks if the hook write/chmod fails, don't report false success (backend#1606) Bugbot (Low) on cli#482: the install steps were ';'-chained, so a failed printf or chmod still exited 0 and printed 'installed'. Git skips a non-executable hook, so make setup could look green while no hook runs. Chain with '&&' so any failure fails the recipe. Uniform across the fleet. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Managed sync from tracebloc/.github/org-standards.md. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
release-train: develop -> staging
Contributor
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e115479. Configure here.
tracebloc-release-train
Bot
added
gate-nudge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated promotion by the release train (RFC-0008 D14). Head is the train-managed
release-train/to-mainbranch (a mirror ofstaging), so it never collides with a human PR. Merged only when the fr-gate is green.Note
Low Risk
Documentation and local-only Makefile/git hook changes; no runtime or CI behavior changes beyond optional contributor tooling.
Overview
Developer workflow:
make setupnow installs a git pre-push hook that runsmake checkbefore each push (skippable withgit push --no-verify). A newmake install-hookstarget installs or refreshes that hook without re-running the full setup; it usesgit rev-parse --git-path hooks, refuses to overwrite a non–tracebloc pre-push hook, and unsets Git env vars in the hook so linked worktrees don’t break nested git during tests.Docs: Org engineer kanban guidance adds that every ticket must have a
Status(new work starts inBacklog), with bugs labeledwork-type:buggoing straight toReady.Reviewed by Cursor Bugbot for commit e115479. Bugbot is set up for automated code reviews on this repo. Configure here.