ci: arm the code-quality gate (soft-fail off) + all-files dispatch - #486
Merged
Conversation
…d#1303) Backlog at zero fleet-wide; the quality contexts are already required on develop. Also adds a workflow_dispatch(all-files) trigger for whole-tree scans (gitleaks baseline). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
👋 Heads-up — Code review queue is at 42 / 30 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
saadqbal
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #1303 flip:
soft-fail: false— from this merge on, ruff/shellcheck/gitleaks/house-rules findings fail the check (which is already marked required on develop). This repo's backlog is at zero, so only new findings can ever block. Also addsworkflow_dispatch(all-files)for whole-tree scans (the gitleaks baseline run follows the merge).This PR is its own proof-run: the armed configuration must pass on this very diff.
Part of tracebloc/backend#1303
🤖 Generated with Claude Code
Note
Medium Risk
Changes CI enforcement only, but merges can now be blocked by new lint/security findings on a required check.
Overview
Arms the required code-quality check by passing
soft-fail: falseinto the sharedcode-quality.ymlworkflow, so ruff, shellcheck, gitleaks, and house-rules findings fail the job instead of advisory-only behavior (backend#1303).Adds
workflow_dispatchwith anall-filesboolean (defaulttrue) so maintainers can trigger a full-repo scan rather than a PR diff, and forwardsall-files: ${{ inputs.all-files || false }}on normal PR runs (false when the input is absent).Reviewed by Cursor Bugbot for commit 31fe64c. Bugbot is set up for automated code reviews on this repo. Configure here.