Skip to content

ci: arm the code-quality gate (soft-fail off) + all-files dispatch - #486

Merged
LukasWodka merged 1 commit into
developfrom
ci/code-quality-required
Jul 30, 2026
Merged

ci: arm the code-quality gate (soft-fail off) + all-files dispatch#486
LukasWodka merged 1 commit into
developfrom
ci/code-quality-required

Conversation

@LukasWodka

@LukasWodka LukasWodka commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

The #1303 flip: soft-fail: false — from this merge on, ruff/shellcheck/gitleaks/house-rules findings fail the check (which is already marked required on develop). This repo's backlog is at zero, so only new findings can ever block. Also adds workflow_dispatch(all-files) for whole-tree scans (the gitleaks baseline run follows the merge).

This PR is its own proof-run: the armed configuration must pass on this very diff.

Part of tracebloc/backend#1303

🤖 Generated with Claude Code


Note

Medium Risk
Changes CI enforcement only, but merges can now be blocked by new lint/security findings on a required check.

Overview
Arms the required code-quality check by passing soft-fail: false into the shared code-quality.yml workflow, so ruff, shellcheck, gitleaks, and house-rules findings fail the job instead of advisory-only behavior (backend#1303).

Adds workflow_dispatch with an all-files boolean (default true) so maintainers can trigger a full-repo scan rather than a PR diff, and forwards all-files: ${{ inputs.all-files || false }} on normal PR runs (false when the input is absent).

Reviewed by Cursor Bugbot for commit 31fe64c. Bugbot is set up for automated code reviews on this repo. Configure here.

…d#1303)

Backlog at zero fleet-wide; the quality contexts are already required on
develop. Also adds a workflow_dispatch(all-files) trigger for whole-tree
scans (gitleaks baseline).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@LukasWodka

Copy link
Copy Markdown
Contributor Author

👋 Heads-up — Code review queue is at 42 / 30

Above the WIP limit. The team convention is to review existing PRs before opening new work.

Open PRs currently in Code review (oldest first):

Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.)

@LukasWodka
LukasWodka merged commit 28737fd into develop Jul 30, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants