ci: guard — chart content change requires a Chart.yaml version bump - #491
Merged
Conversation
A Helm chart repo publishes only on a version change, so a template/values edit without a Chart.yaml bump reaches no installs. That is exactly how the perIngestionTables flag block shipped to staging yet never rendered (PR #472 changed the template but not the version, so the published 1.9.7 stayed stale). This blocking gate makes the bump non-optional. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
👋 Heads-up — Code review queue is at 37 / 30 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
saadqbal
approved these changes
Jul 30, 2026
Contributor
Author
|
/fr-pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents the gap Divya's staging test surfaced: PR #472 changed
client/templates/jobs-manager-deployment.yaml(theperIngestionTablesenv block) without bumpingChart.yaml, so the published1.9.7package stayed stale and the flag never rendered on installs — even though the source was correct and the helm-unittest passed (it renders the source, not the published artifact).This blocking gate: any PR touching
client/templates/**orclient/values.yamlmust also bumpclient/Chart.yaml'sversion:line, else it fails. Non-chart PRs are unaffected (guard short-circuits to N/A).After merge, add it to
develop/staging/mainrequired status checks (admin) so it actually blocks.Sibling guard for the ingestor image (which had the analogous gap — #408 merged without a
__version__bump, so no image was released): tracebloc/data-ingestors (next PR).Epic: tracebloc/backend#1151
🤖 Generated with Claude Code
Note
Low Risk
CI-only guard with read-only repo permissions; no runtime or deployment behavior changes until the check is added to required status checks.
Overview
Adds a blocking PR workflow so Helm chart edits cannot merge without a publishable version bump.
On every pull request, if the diff touches
client/templates/**orclient/values.yaml, the job requiresclient/Chart.yamlto include a new+version:line; otherwise it fails with an actionable error. PRs that only change non-chart paths exit successfully with “guard N/A.”This closes the gap where template/values fixes could pass tests and land in git but never ship to installs because the chart repo only publishes when
versionchanges.Reviewed by Cursor Bugbot for commit efa2b25. Bugbot is set up for automated code reviews on this repo. Configure here.