Skip to content

ci: guard — chart content change requires a Chart.yaml version bump - #491

Merged
LukasWodka merged 1 commit into
developfrom
ci/chart-version-guard
Jul 30, 2026
Merged

ci: guard — chart content change requires a Chart.yaml version bump#491
LukasWodka merged 1 commit into
developfrom
ci/chart-version-guard

Conversation

@LukasWodka

@LukasWodka LukasWodka commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Prevents the gap Divya's staging test surfaced: PR #472 changed client/templates/jobs-manager-deployment.yaml (the perIngestionTables env block) without bumping Chart.yaml, so the published 1.9.7 package stayed stale and the flag never rendered on installs — even though the source was correct and the helm-unittest passed (it renders the source, not the published artifact).

This blocking gate: any PR touching client/templates/** or client/values.yaml must also bump client/Chart.yaml's version: line, else it fails. Non-chart PRs are unaffected (guard short-circuits to N/A).

After merge, add it to develop/staging/main required status checks (admin) so it actually blocks.

Sibling guard for the ingestor image (which had the analogous gap — #408 merged without a __version__ bump, so no image was released): tracebloc/data-ingestors (next PR).

Epic: tracebloc/backend#1151

🤖 Generated with Claude Code


Note

Low Risk
CI-only guard with read-only repo permissions; no runtime or deployment behavior changes until the check is added to required status checks.

Overview
Adds a blocking PR workflow so Helm chart edits cannot merge without a publishable version bump.

On every pull request, if the diff touches client/templates/** or client/values.yaml, the job requires client/Chart.yaml to include a new +version: line; otherwise it fails with an actionable error. PRs that only change non-chart paths exit successfully with “guard N/A.”

This closes the gap where template/values fixes could pass tests and land in git but never ship to installs because the chart repo only publishes when version changes.

Reviewed by Cursor Bugbot for commit efa2b25. Bugbot is set up for automated code reviews on this repo. Configure here.

A Helm chart repo publishes only on a version change, so a template/values
edit without a Chart.yaml bump reaches no installs. That is exactly how the
perIngestionTables flag block shipped to staging yet never rendered (PR #472
changed the template but not the version, so the published 1.9.7 stayed
stale). This blocking gate makes the bump non-optional.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@LukasWodka

Copy link
Copy Markdown
Contributor Author

👋 Heads-up — Code review queue is at 37 / 30

Above the WIP limit. The team convention is to review existing PRs before opening new work.

Open PRs currently in Code review (oldest first):

Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.)

@LukasWodka
LukasWodka merged commit df0f332 into develop Jul 30, 2026
14 checks passed
@LukasWodka

Copy link
Copy Markdown
Contributor Author

/fr-pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants