chore: re-baseline the PR template on the org one - #510
Merged
Conversation
Contributor
Author
|
👋 Heads-up — Code review queue is at 49 / 30 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
saadqbal
approved these changes
Jul 31, 2026
Contributor
Author
|
/fr-pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-baselines this repo's
.github/pull_request_template.mdon the org template, keeping only the checks that are genuinely specific to this repo. Implements the recommendation on backend#1373.This repo is one of just two (with the other of
client/cli) that earns its own template — the other eight are being deleted so they inherit the org one, because their copies were byte-identical, strictly older subsets, or differed only in which repo the cross-repo example named.What this changes. The body is now the org template verbatim, plus the repo-specific checklist lines that were already here. Net effect beyond that:
developmerge (docs: note that closing keywords do not fire on a develop merge .github#113) — a caveat this repo had locally, now shared with everyone;Ongoing cost, stated plainly: because this repo keeps its own file, future org-template changes will not reach it automatically — it will need re-baselining again. That is the price of the repo-specific lines, and it is why only two repos keep one.
Note
Low Risk
Documentation-only PR template changes with no runtime, security, or deployment behavior impact.
Overview
Re-baselines this repo’s
.github/pull_request_template.mdon the shared org template, keeping the checklist lines that are specific to this repo (cross-repo issue syntax,STYLE.md/check-style.sh, and related guidance).The Related comment now uses
tracebloc/client-runtime#456as the cross-repo example and adds that closing keywords do not fire when merging todevelop, so authors must confirm issues actually closed.The checklist gains the expand-then-contract item for cross-repo dependencies (additive ship first, or mark breaking change with rollout in Deployment notes), and the STYLE.md terminal-output line is restored after having been dropped from this copy.
Reviewed by Cursor Bugbot for commit 47e43aa. Bugbot is set up for automated code reviews on this repo. Configure here.