Skip to content

docs(ci): /fr-pass advances staging → prod only (backend#1405 D6) - #531

Merged
LukasWodka merged 1 commit into
developfrom
docs/fr-pass-caller-staging-only
Aug 3, 2026
Merged

docs(ci): /fr-pass advances staging → prod only (backend#1405 D6)#531
LukasWodka merged 1 commit into
developfrom
docs/fr-pass-caller-staging-only

Conversation

@LukasWodka

@LukasWodka LukasWodka commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

The header comment on this repo's /fr-pass caller describes a transition that does not exist:

# from "FR on dev" → "Ready for staging" or "FR on staging" → "Ready for prod".

RFC-BACKEND-1405 D6 retired the dev-side review. On dev is now set automatically when the release train merges to develop, so there is no FR on dev column and nothing for /fr-pass to advance before staging. /fr-pass has exactly one gate: FR on stagingReady for prod.

The reusable workflow this calls (tracebloc/.github, .github/workflows/fr-pass-comment.yml) has only ever implemented the staging hop, and documents it correctly at the top of the file:

#   FR on staging  →  Ready for prod
# (D6: the dev-side review is gone — "On dev" is automatic — so /fr-pass only
#  applies at staging, the single functional-review gate.)

Verified against the reusable's implementation: the only transition in its column table is "FR on staging") NEXT="Ready for prod", and its refusal message states that /fr-pass "only advances FR on staging → Ready for prod (the one functional-review gate)". So this was the comment drifting away from the code.

Comment-only. No logic, no triggers, no inputs changed.

Scope note

This stale comment is byte-identical across 14 repos, plus a differently-worded copy in the tracebloc/.github template it was copied from. A pull request cannot span repositories, so this is one of 15 PRs — the template in tracebloc/.github included, because leaving that one stale would reintroduce the drift on the next copy.

🤖 Generated with Claude Code


Note

Low Risk
Documentation-only comment edits in a GitHub Actions caller workflow; no triggers, jobs, or reusable workflow wiring changed.

Overview
Updates the header comments in fr-pass-comment-caller.yml so they match how /fr-pass actually works after RFC-BACKEND-1405 D6.

The old text implied two kanban hops (FR on dev → Ready for staging and FR on staging → Ready for prod). The new text documents a single gate: FR on staging → Ready for prod, and explains that dev-side FR was retired because On dev is set automatically when the release train merges to develop.

No workflow behavior changeson, jobs, reusable workflow reference, and secrets are unchanged.

Reviewed by Cursor Bugbot for commit cf0c06c. Bugbot is set up for automated code reviews on this repo. Configure here.

The caller's header described a "FR on dev" -> "Ready for staging" transition
that does not exist. RFC-BACKEND-1405 D6 retired the dev-side review -- "On dev"
is set automatically when the train merges to develop -- so /fr-pass applies at
exactly one gate: FR on staging -> Ready for prod.

The reusable workflow it calls has only ever implemented the staging hop and
documents that correctly at the top of the file, so this was the comment drifting
away from the code, not a behaviour change. Comment-only; no logic touched.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@LukasWodka
LukasWodka requested a review from saadqbal August 2, 2026 15:09

@divyasinghds divyasinghds left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified: comment-only change, byte-identical to the other 13 callers, and the new header matches the reusable's actual behavior (staging→prod only; dev-side review retired per RFC-1405 D6). LGTM.

@LukasWodka LukasWodka self-assigned this Aug 3, 2026
@LukasWodka
LukasWodka merged commit e712873 into develop Aug 3, 2026
15 checks passed
@LukasWodka

Copy link
Copy Markdown
Contributor Author

/fr-pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants