docs(ci): /fr-pass advances staging → prod only (backend#1405 D6) - #531
Merged
Conversation
The caller's header described a "FR on dev" -> "Ready for staging" transition that does not exist. RFC-BACKEND-1405 D6 retired the dev-side review -- "On dev" is set automatically when the train merges to develop -- so /fr-pass applies at exactly one gate: FR on staging -> Ready for prod. The reusable workflow it calls has only ever implemented the staging hop and documents that correctly at the top of the file, so this was the comment drifting away from the code, not a behaviour change. Comment-only; no logic touched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
divyasinghds
approved these changes
Aug 3, 2026
divyasinghds
left a comment
Contributor
There was a problem hiding this comment.
Verified: comment-only change, byte-identical to the other 13 callers, and the new header matches the reusable's actual behavior (staging→prod only; dev-side review retired per RFC-1405 D6). LGTM.
Contributor
Author
|
/fr-pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header comment on this repo's
/fr-passcaller describes a transition that does not exist:RFC-BACKEND-1405 D6 retired the dev-side review.
On devis now set automatically when the release train merges todevelop, so there is noFR on devcolumn and nothing for/fr-passto advance before staging./fr-passhas exactly one gate:FR on staging→Ready for prod.The reusable workflow this calls (
tracebloc/.github,.github/workflows/fr-pass-comment.yml) has only ever implemented the staging hop, and documents it correctly at the top of the file:Verified against the reusable's implementation: the only transition in its column table is
"FR on staging") NEXT="Ready for prod", and its refusal message states that/fr-pass"only advances FR on staging → Ready for prod (the one functional-review gate)". So this was the comment drifting away from the code.Comment-only. No logic, no triggers, no inputs changed.
Scope note
This stale comment is byte-identical across 14 repos, plus a differently-worded copy in the
tracebloc/.githubtemplate it was copied from. A pull request cannot span repositories, so this is one of 15 PRs — the template intracebloc/.githubincluded, because leaving that one stale would reintroduce the drift on the next copy.🤖 Generated with Claude Code
Note
Low Risk
Documentation-only comment edits in a GitHub Actions caller workflow; no triggers, jobs, or reusable workflow wiring changed.
Overview
Updates the header comments in
fr-pass-comment-caller.ymlso they match how/fr-passactually works after RFC-BACKEND-1405 D6.The old text implied two kanban hops (FR on dev → Ready for staging and FR on staging → Ready for prod). The new text documents a single gate: FR on staging → Ready for prod, and explains that dev-side FR was retired because On dev is set automatically when the release train merges to
develop.No workflow behavior changes —
on, jobs, reusable workflow reference, and secrets are unchanged.Reviewed by Cursor Bugbot for commit cf0c06c. Bugbot is set up for automated code reviews on this repo. Configure here.