release-train: develop -> staging - #573
Merged
Merged
Conversation
…ign skip Bugbot on the prod promotion (client#571), Medium. The settled-gate ran `kubectl rollout status` and treated ANY non-zero as 'in progress -- skip' (exit 0). But non-zero is also NotFound, RBAC denial, and API errors -- so a misconfigured or unreachable deployment left the CronJob GREEN forever while image refresh never ran. And the call had no --request-timeout (only --timeout, the rollout wait), so a wedged API server could hang the tick with no activeDeadlineSeconds, and concurrencyPolicy: Forbid would then block every later tick. Now: a non-zero rollout status is disambiguated -- if `kubectl get deployment` still succeeds the deployment is genuinely present-but-unsettled (legit skip, exit 0); otherwise it is an error the job SURFACES (exit 1). --request-timeout=15s bounds each API call, and activeDeadlineSeconds=300 caps the whole tick as a backstop. Refs: tracebloc/backend#1426
…ign skip Bugbot on the prod promotion (client#571), Medium. The settled-gate treated ANY non-zero `kubectl rollout status` as 'in progress -- skip' (exit 0). But non-zero is also NotFound, RBAC denial, and API errors, so a misconfigured or unreachable deployment left the CronJob GREEN forever while refresh never ran. The call also had no --request-timeout (only --timeout, the rollout wait), so a wedged API could hang the tick with no activeDeadlineSeconds -- and concurrencyPolicy: Forbid then blocks every later tick. Now a non-zero status is disambiguated: if `kubectl get deployment` still succeeds the deployment is genuinely present-but-unsettled (legit skip, exit 0); otherwise it is surfaced (exit 1). --request-timeout=15s bounds each API call and activeDeadlineSeconds=300 caps the whole tick. (Corrects a prior no-op commit on this branch that committed the file unmodified because a patch anchor mismatched the real indentation.) Refs: tracebloc/backend#1426
…ercut it Bugbot on client#572, High. My 300s deadline was BELOW the default imageRefresh.rolloutTimeout of 10m -- a tick doing rollout restart + rollout status could be DeadlineExceeded mid-wait, so the post-success annotation never lands and later ticks re-restart forever. Raised to 1800s (well above 10m) with a comment tying it to rolloutTimeout; it is only a backstop since every call is --request-timeout-bounded.
fix(chart): image-refresh CronJob must not treat every error as a benign skip (#571)
Contributor
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 6f503d2. Configure here.
tracebloc-release-train
Bot
added
gate-nudge
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 6f503d2. Configure here.
tracebloc-release-train
Bot
added
gate-nudge
Contributor
Author
|
/fr-pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated promotion by the release train (RFC-0008 D14). Head is the train-managed
release-train/to-stagingbranch (a mirror ofdevelop), so it never collides with a human PR. Merged only when the fr-gate is green.Note
Medium Risk
Changes when the image-refresh CronJob fails vs skips, which affects automatic rollout of jobs-manager/pods-monitor; misclassification could either churn restarts or leave stale images until noticed.
Overview
Bumps the client Helm chart to 1.9.12 as part of the develop → staging release train.
Image-refresh CronJob behavior is tightened so operational failures are visible instead of silently succeeding:
kubectl rollout statusandget deploymentuse--request-timeout=15sso a wedged API cannot hang a tick indefinitely whileconcurrencyPolicy: Forbidblocks later runs.exit 1) instead of exiting 0 and leaving the CronJob green while refresh never runs (release-train: staging -> main #571).activeDeadlineSeconds: 1800so a legitimate tick is not killed mid-rollout statuswait (must exceed the default 10m rollout timeout); without it, digest annotations might never land and later ticks could restart forever (fix(chart): image-refresh CronJob must not treat every error as a benign skip (#571) #572).Reviewed by Cursor Bugbot for commit 6f503d2. Bugbot is set up for automated code reviews on this repo. Configure here.