[ENH] Immlib over pimms#108
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the pimms library with immlib throughout the AFQ codebase. The change involves updating the dependency in setup.cfg and systematically replacing all pimms imports and function calls with their immlib equivalents across multiple task modules.
Key changes:
- Updated dependency from
pimmstoimmlibin setup.cfg - Replaced all
pimms.calc()decorators withimmlib.calc() - Updated all
pimms.plan()calls toimmlib.plan() - Modified comments referencing
pimmsto referenceimmlibinstead
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| setup.cfg | Updated package dependency from pimms to immlib |
| AFQ/tasks/viz.py | Replaced pimms imports and decorators with immlib equivalents |
| AFQ/tasks/tractography.py | Updated all pimms.calc decorators and plan calls to use immlib |
| AFQ/tasks/segmentation.py | Converted pimms decorators and function calls to immlib |
| AFQ/tasks/mapping.py | Replaced pimms usage with immlib throughout the module |
| AFQ/tasks/decorators.py | Updated comments referencing pimms to mention immlib |
| AFQ/tasks/data.py | Comprehensive replacement of pimms decorators and calls with immlib |
| AFQ/recognition/preprocess.py | Updated pimms imports and function calls to immlib |
| AFQ/api/utils.py | Modified type checking from pimms.calculation.Calc to immlib.workflow.calc |
| AFQ/api/participant.py | Updated comment referencing pimms plans to immlib plans |
|
@arokem this is ready for review/merge |
|
This looks good to me! @noahbenson: could I trouble you to take a quick look at this PR? This replaces pimms with immlib in pyAFQ |
|
I just looked through the code! There's plenty of pyAFQ-specific stuff that I can't critique, but the immlib code all looks pretty idiomatic. FWIW, this is the first major "real-world" test case for immlib, so let me know if it looks like any bugs are arising from it! |
|
Thanks for taking a look! I'll go ahead and merge and we'll keep an eye out for any weirdnesses. |
Uh oh!
There was an error while loading. Please reload this page.