Nightly Fixes post immlib#112
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements fixes for the AFQ codebase following the introduction of immlib, addressing issues with task planning and workflow naming.
- Updates tractography task planning to properly wrap image getters with
as_filecalls - Fixes mapping task key naming and adds type checking for reg_subject parameter
- Removes unused kwargs in data task planning
- Disambiguates nightly test workflow names for better identification
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| AFQ/tasks/tractography.py | Wraps probseg functions with as_file calls for proper file handling |
| AFQ/tasks/mapping.py | Fixes task key naming and adds reg_subject type checking |
| AFQ/tasks/data.py | Removes unused brain_mask_definition from kwargs |
| .github/workflows/*.yml | Updates workflow names to be more descriptive and unique |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
|
LGTM! I think we can merge as soon as the CI comes back green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Names nightly tests and fixes two currently failing