[DOC] more explicit cleaning testing#118
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds more explicit testing for the cleaning functionality in pyAFQ, addressing potential issues related to older versions of the library. The changes include enhanced debugging capabilities and more thorough validation of streamline data integrity during cleaning operations.
Key changes:
- Added logging configuration for better debugging during cleaning operations
- Implemented comprehensive validation tests to ensure streamline data consistency
- Enhanced existing tests with node-by-node verification of streamline integrity
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| AFQ/recognition/tests/test_utils.py | Added logging setup for debugging and new test_cleaning() function with detailed streamline validation |
| AFQ/recognition/tests/test_recognition.py | Enhanced test_segment_return_idx() with node-level streamline integrity checks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
|
A PR that is all just tests is probably my favorite kind of PR. ⭐ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe #117 is just due to using an older version of pyAFQ. But these tests are helpful anyways