[ENH] Remove co-located warnings by moving forceps into separate bd, update default_18 to default#138
Merged
Merged
Conversation
…update default_18 to default_20
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request renames default18_bd() to default_bd() and extracts the Forceps Major and Forceps Minor bundles into a separate forceps_bd() function to resolve co-located warnings. Additionally, it includes several spelling corrections across documentation and comments.
Key Changes
- Renamed
default18_bd()todefault_bd()throughout the codebase - Extracted Forceps Major and Forceps Minor bundles from
default_bd()into a newforceps_bd()function - Fixed multiple spelling errors in comments, documentation, and examples
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| AFQ/api/bundle_dict.py | Renamed function from default18_bd to default_bd and created separate forceps_bd() function |
| AFQ/tasks/data.py | Updated default bundle reference from default18_bd() to default_bd() |
| AFQ/tests/test_bundle_dict.py | Updated test references from default18_bd() to default_bd() |
| AFQ/tests/test_api.py | Updated test references from default18_bd() to default_bd() |
| examples/tutorial_examples/plot_007_rois.py | Updated function call from default18_bd() to default_bd() |
| examples/tutorial_examples/plot_006_bids_layout.py | Updated function call from default18_bd() to default_bd() |
| examples/howto_examples/vof_example.py | Updated function call from default18_bd() to default_bd() |
| examples/howto_examples/pyafq_2.py | Updated function call and fixed spelling errors in comments |
| examples/howto_examples/plot_stages_of_tractometry.py | Fixed spelling errors in comments |
| examples/howto_examples/optic_radiations.py | Updated function reference in comment and modified citation |
| examples/howto_examples/afq_fwdti.py | Updated function call from default18_bd() to default_bd() |
| examples/howto_examples/afq_callosal.py | Updated function reference in comment |
| examples/howto_examples/add_custom_bundle.py | Updated function reference in comment and fixed spelling error |
| examples/howto_examples/use_subject_space_rois_from_freesurfer.py | Fixed spelling error in comment |
| docs/source/reference/bundledict.rst | Updated function references and fixed spelling errors |
| .codespellrc | Added "abd" to ignore-words-list |
Comments suppressed due to low confidence (1)
AFQ/api/bundle_dict.py:23
- The newly created
forceps_bdfunction is not exported in the__all__list. This function should be added to the exports so it can be imported and used by users who want to include the forceps bundles in their analysis.
__all__ = [
"BundleDict",
"default_bd",
"reco_bd",
"callosal_bd",
"cerebellar_bd",
"baby_bd",
]
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arokem
reviewed
Jan 8, 2026
arokem
left a comment
Member
There was a problem hiding this comment.
LGTM! I think that copilot did catch some tests that need to be fixed? But also some of those comments are not correct, I believe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.