Skip to content

[ENH] From qsiprep#142

Merged
36000 merged 3 commits into
tractometry:mainfrom
36000:from_qsiprep
Jan 12, 2026
Merged

[ENH] From qsiprep#142
36000 merged 3 commits into
tractometry:mainfrom
36000:from_qsiprep

Conversation

@36000

@36000 36000 commented Jan 10, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings January 10, 2026 19:41
@36000 36000 added this to the pyAFQ 3.0 milestone Jan 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a new from_qsiprep class method to GroupAFQ for easier initialization when working with QSIPrep-preprocessed data. The PR also improves error handling by introducing a new val_from_plan utility function that unwraps nested LazyError exceptions to provide clearer error messages.

Changes:

  • Added GroupAFQ.from_qsiprep() class method to simplify initialization with QSIPrep data
  • Introduced val_from_plan() utility function for better error handling when accessing plan attributes
  • Updated example tutorial to demonstrate the new from_qsiprep method

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
AFQ/api/group.py Adds from_qsiprep class method with automatic BIDS filters and image configuration for QSIPrep data; updates export and export_up_to methods to use new error handling
AFQ/api/participant.py Updates export and export_up_to methods to use new val_from_plan utility for consistent error handling
AFQ/api/utils.py Adds val_from_plan function for unwrapping nested LazyError exceptions; updates check_attribute to return string "help" instead of False for better consistency
examples/tutorial_examples/plot_001_group_afq_api.py Adds documentation section demonstrating usage of the new from_qsiprep class method
.github/workflows/nightly_reco80_test.yml Increases swap space from 16G to 32G for CI testing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread AFQ/api/group.py
Comment thread AFQ/api/group.py
@arokem

arokem commented Jan 10, 2026

Copy link
Copy Markdown
Member

Could you please rebase after the merge of #141 ?

@arokem

arokem commented Jan 12, 2026

Copy link
Copy Markdown
Member

LGTM! If you agree that this is ready, please go ahead and merge when you get a chance.

@36000
36000 merged commit f3d0e36 into tractometry:main Jan 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants