[ENH] From qsiprep#142
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a new from_qsiprep class method to GroupAFQ for easier initialization when working with QSIPrep-preprocessed data. The PR also improves error handling by introducing a new val_from_plan utility function that unwraps nested LazyError exceptions to provide clearer error messages.
Changes:
- Added
GroupAFQ.from_qsiprep()class method to simplify initialization with QSIPrep data - Introduced
val_from_plan()utility function for better error handling when accessing plan attributes - Updated example tutorial to demonstrate the new
from_qsiprepmethod
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
AFQ/api/group.py |
Adds from_qsiprep class method with automatic BIDS filters and image configuration for QSIPrep data; updates export and export_up_to methods to use new error handling |
AFQ/api/participant.py |
Updates export and export_up_to methods to use new val_from_plan utility for consistent error handling |
AFQ/api/utils.py |
Adds val_from_plan function for unwrapping nested LazyError exceptions; updates check_attribute to return string "help" instead of False for better consistency |
examples/tutorial_examples/plot_001_group_afq_api.py |
Adds documentation section demonstrating usage of the new from_qsiprep class method |
.github/workflows/nightly_reco80_test.yml |
Increases swap space from 16G to 32G for CI testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Could you please rebase after the merge of #141 ? |
Member
|
LGTM! If you agree that this is ready, please go ahead and merge when you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.