[ENH] Provide Apptainer .def file as reference#149
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request replaces the placeholder-based Apptainer build system with a simplified reference definition file for building pyAFQ GPU containers. The old approach required a build script to substitute placeholders, while the new approach provides a straightforward, self-contained definition file.
Changes:
- Removed
cuda_track_template.defand its associated build scriptcuda_build.sh - Added
pyafq_with_gpu_template.defas a reference Apptainer definition file that installs pyAFQ directly from GitHub
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| gpu_docker/pyafq_with_gpu_template.def | New simplified Apptainer definition file for GPU-enabled pyAFQ installation |
| gpu_docker/cuda_track_template.def | Removed old template-based definition file that required placeholder substitution |
| gpu_docker/cuda_build.sh | Removed build script that was used to process the old template file |
Comments suppressed due to low confidence (1)
gpu_docker/cuda_track_template.def:1
- The file cuda_track_template.def is referenced in the documentation at docs/source/howto/singularity.rst line 9. Removing this file without updating the documentation will create a broken link. The documentation should be updated to reference the new pyafq_with_gpu_template.def file instead.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we had a def file for installing GPUstreamlines the old system and installing pyAFQ from a local repo into apptainer. This updates to the new GPUstreamlines and updates to install pyAFQ from main, which I think will be more generally useful.