Skip to content

[ENH] Provide Apptainer .def file as reference#149

Merged
arokem merged 2 commits into
tractometry:mainfrom
36000:organize_apptainer
Jan 15, 2026
Merged

[ENH] Provide Apptainer .def file as reference#149
arokem merged 2 commits into
tractometry:mainfrom
36000:organize_apptainer

Conversation

@36000

@36000 36000 commented Jan 14, 2026

Copy link
Copy Markdown
Collaborator

Previously, we had a def file for installing GPUstreamlines the old system and installing pyAFQ from a local repo into apptainer. This updates to the new GPUstreamlines and updates to install pyAFQ from main, which I think will be more generally useful.

Copilot AI review requested due to automatic review settings January 14, 2026 21:48
@36000 36000 added this to the pyAFQ 3.0 milestone Jan 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request replaces the placeholder-based Apptainer build system with a simplified reference definition file for building pyAFQ GPU containers. The old approach required a build script to substitute placeholders, while the new approach provides a straightforward, self-contained definition file.

Changes:

  • Removed cuda_track_template.def and its associated build script cuda_build.sh
  • Added pyafq_with_gpu_template.def as a reference Apptainer definition file that installs pyAFQ directly from GitHub

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
gpu_docker/pyafq_with_gpu_template.def New simplified Apptainer definition file for GPU-enabled pyAFQ installation
gpu_docker/cuda_track_template.def Removed old template-based definition file that required placeholder substitution
gpu_docker/cuda_build.sh Removed build script that was used to process the old template file
Comments suppressed due to low confidence (1)

gpu_docker/cuda_track_template.def:1

  • The file cuda_track_template.def is referenced in the documentation at docs/source/howto/singularity.rst line 9. Removing this file without updating the documentation will create a broken link. The documentation should be updated to reference the new pyafq_with_gpu_template.def file instead.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread gpu_docker/pyafq_with_gpu_template.def
Comment thread gpu_docker/pyafq_with_gpu_template.def
Comment thread gpu_docker/pyafq_with_gpu_template.def
Comment thread gpu_docker/pyafq_with_gpu_template.def
@arokem
arokem merged commit 684ae98 into tractometry:main Jan 15, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants