[WIP/FIX] GPUStreamlines#153
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds initialization logic for the rng_seed parameter in the gpu_track function to ensure a random seed is generated when None is provided.
Changes:
- Add conditional initialization of
rng_seedto generate a random integer when it is None
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+156
to
+157
| if rng_seed is None: | ||
| rng_seed = np.random.randint(0, 2**31 - 1) |
There was a problem hiding this comment.
The rng_seed initialization occurs after gen_seeds() is called (lines 146-154). This means gen_seeds() receives None when rng_seed is None, while GPUTracker receives the newly generated random seed, causing inconsistent seeding behavior between seed generation and tracking. Move this initialization to before line 146 to ensure both gen_seeds() and GPUTracker use the same seed value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will also need to update GPUStreamlines to 2.1 in this PR