Skip to content

More fixes after merging #156#159

Merged
36000 merged 3 commits into
tractometry:mainfrom
arokem:fix_after_156
Jan 21, 2026
Merged

More fixes after merging #156#159
36000 merged 3 commits into
tractometry:mainfrom
arokem:fix_after_156

Conversation

@arokem

@arokem arokem commented Jan 21, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings January 21, 2026 01:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new pytest marker nightly_slr to the test configuration in pyproject.toml. The marker is intended to categorize tests related to Streamline-based Linear Registration (SLR), similar to existing markers for other test categories like nightly_anisotropic, nightly_reco, and nightly_custom. The marker is already referenced in CI workflows to exclude these tests from regular test runs.

Changes:

  • Added nightly_slr marker to the pytest markers list in pyproject.toml

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyproject.toml
"nightly_reco80",
"nightly_custom",
"nightly_slr",
"nightly",

Copilot AI Jan 21, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a duplicate "nightly" marker in the markers list. The marker appears on line 31 and again on line 38 (after the newly added "nightly_slr" marker). One of these duplicate entries should be removed.

Suggested change
"nightly",

Copilot uses AI. Check for mistakes.
This happens on the CI in the absence of an IPython installation.
For example, when building and installing a minimal sdist.
@arokem arokem changed the title Adds on more marking, while we're at it. More fixes after merging #156 Jan 21, 2026
Comment thread AFQ/tests/test_viz.py
import pytest

from AFQ.viz.utils import Viz
try:

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this look ok to you @36000 ?

@36000

36000 commented Jan 21, 2026

Copy link
Copy Markdown
Collaborator

This looks good to me!

@36000
36000 merged commit d1f63e1 into tractometry:main Jan 21, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants