Actually decorate this test.#160
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a mistake where a pytest decorator was not properly applied to a test function. The decorator line was missing the @ symbol, which prevented it from actually decorating the test function.
Changes:
- Added the
@symbol to convert a standalone statement into a proper pytest decorator for thetest_viz_name_errors()function
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| pytest.mark.skip(not Viz, "Skipping viz tests, unable to import viz utils") | ||
|
|
||
|
|
||
| @pytest.mark.skip(not Viz, "Skipping viz tests, unable to import viz utils") |
There was a problem hiding this comment.
The decorator should use pytest.mark.skipif instead of pytest.mark.skip when conditionally skipping based on a condition. The correct syntax is @pytest.mark.skipif(not Viz, reason="Skipping viz tests, unable to import viz utils"). The pytest.mark.skip decorator is used for unconditionally skipping tests and doesn't accept a condition parameter.
Suggested change
| @pytest.mark.skip(not Viz, "Skipping viz tests, unable to import viz utils") | |
| @pytest.mark.skipif(not Viz, reason="Skipping viz tests, unable to import viz utils") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a silly mistake in my previous effort here.