One more try here.#161
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request corrects a pytest decorator from @pytest.mark.skip to @pytest.mark.skipif in the test_viz.py file. The original code used the wrong pytest marker for conditionally skipping tests.
Changes:
- Fixed pytest decorator from
skiptoskipifto properly handle conditional test skipping
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
|
|
||
| @pytest.mark.skip(not Viz, "Skipping viz tests, unable to import viz utils") | ||
| @pytest.mark.skipif(not Viz, "Skipping viz tests, unable to import viz utils") |
There was a problem hiding this comment.
The skipif marker is missing the 'reason=' keyword argument. According to pytest documentation and the pattern used elsewhere in this codebase (see test_nn.py lines 21 and 38), the reason string should be passed with the 'reason=' keyword. The correct syntax should be: @pytest.mark.skipif(not Viz, reason="Skipping viz tests, unable to import viz utils")
Suggested change
| @pytest.mark.skipif(not Viz, "Skipping viz tests, unable to import viz utils") | |
| @pytest.mark.skipif(not Viz, reason="Skipping viz tests, unable to import viz utils") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.