MAINT: Move setuptools_scm config to pyproject.toml#165
Merged
Conversation
Also gets rid of horrid hack to avoid local versions, which cannot be uploaded to testpypi for purpose of testing uploads on merges.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates setuptools_scm configuration from setup.py to pyproject.toml and replaces a custom local version hack with the built-in no-local-version scheme. This modernizes the package configuration and solves the TestPyPI upload issue more cleanly.
Changes:
- Removed custom
local_versionfunction and related imports from setup.py - Moved setuptools_scm configuration to pyproject.toml using the
no-local-versionbuilt-in scheme - Maintained the same version file output path (
AFQ/version.py)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| setup.py | Removed setuptools_scm configuration, custom local_version function, and unused imports (string, setuptools_scm.get_version) |
| pyproject.toml | Added setuptools_scm configuration with write_to and local_scheme settings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also gets rid of horrid hack to avoid local versions, which cannot be uploaded to testpypi for purpose of testing uploads on merges.