[ENH] Have t1/b0 be the default tp instead of t1#181
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new “T1w over mean b0” derived image intended to serve as a proxy for R1 (per the linked Moskovich et al. work), and switches the default scalar list to use this quantity instead of plain T1w.
Changes:
- Added a new
t1w_b0scalar computation (t1w_over_b0) that resamples masked T1w into b0 space and computes T1w/b0. - Updated default scalar selection in
get_data_planto includet1w_b0for both single- and multi-shell datasets. - Added a new BibTeX entry for the referenced Moskovich et al. (2024) work.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/source/references.bib | Adds citation metadata for the Moskovich et al. reference used by the new scalar. |
| AFQ/tasks/data.py | Implements t1w_b0 and changes the default scalar list to use it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
@arokem thoughts? |
36000
changed the title
arokem
reviewed
Apr 27, 2026
arokem
reviewed
Apr 27, 2026
arokem
reviewed
Apr 27, 2026
arokem
reviewed
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on this paper:
https://onlinelibrary.wiley.com/doi/full/10.1002/hbm.70102