[FIX] SLF and callosal defaults#182
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts default cleaning behavior for SLF sub-bundles and callosal bundles, aligning bundle defaults with current segmentation/cleaning preferences ahead of the 3.0 release.
Changes:
- Adds stricter Mahalanobis cleaning parameters applied to all SLF sub-bundles.
- Removes Isolation Forest cleaning from callosal bundle defaults, reverting them to Mahalanobis-based cleaning.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+558
to
+565
| criteria_for_all={ | ||
| "mahal": { | ||
| "distance_threshold": 3, | ||
| "length_threshold": 3, | ||
| "clean_rounds": 5, | ||
| "remove_lengths": "both", | ||
| }, | ||
| }, |
Collaborator
Author
|
TODO: try seeding in corpus callosum |
36000
changed the title
36000
force-pushed
the
stronger_cleaning_before_release
branch
from
May 8, 2026 21:55
c543661 to
d50ed12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callosal Bundles returned to Mahalanobis cleaning, for now.
Stronger cleaning on SLF subbundles.
Both of these may need refinement before 3.0 ; Motor and Temporal bundles may need to be removed. They often are more incorrect compared to our other default bundles.