TST: Test both for small number of seeds and for failure to find bund…#186
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the test_API_type_checking nightly test to explicitly cover (1) the new early failure when using random_seeds=True with too few seeds and (2) the downstream failure mode where no bundles are recognized when seeding is increased beyond that threshold. This aligns the test expectations with the error now raised during tractography plan construction and addresses the referenced nightly failure.
Changes:
- Replace the previous single assertion of
"Fatal: No bundles recognized."with an assertion for the newer low-seedValueErrormessage whenn_seedsis very small. - Add a second test case using a larger
n_seedsto still assert the"Fatal: No bundles recognized."failure mode.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -532,6 +537,31 @@ def test_API_type_checking(): | |||
| raise e | |||
| del myafq | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…les.
Addresses nightly failure in https://github.com/tractometry/pyAFQ/actions/runs/25626952221/job/75223677395#step:7:451