TST: Refactor API test#188
Merged
Merged
Conversation
This test raises the error on initialization, so no object is created.
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors test_API_type_checking to handle cases where the expected failure occurs during GroupAFQ initialization (instead of during a later export), preventing the nightly failure where no object is created.
Changes:
- Moves
GroupAFQ(...)construction into thetry/except LazyErrorunwrapping block for the “random seeds with low n_seeds” validation case. - Removes the unconditional
del myafqcleanup for that case (sincemyafqmay never be assigned if initialization fails early).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
516
to
+532
| try: | ||
| myafq.export("bundles") | ||
| myafq = GroupAFQ( | ||
| bids_path, | ||
| dwi_preproc_pipeline="vistasoft", | ||
| t1_preproc_pipeline="freesurfer", | ||
| mapping_definition=IdentityMap(), | ||
| reg_subject_spec="dti_fa_subject", | ||
| tracking_params={ | ||
| "n_seeds": 10, | ||
| "rng_seed": seed, | ||
| "random_seeds": True, | ||
| "seed_mask": ScalarImage("dti_fa"), | ||
| "directions": "det", | ||
| "odf_model": "DTI", | ||
| }, | ||
| bundle_info=abd.default_bd()["Left Arcuate", "Right Arcuate"], | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test raises the error on initialization, so no object is created.
Fixes this nightly failure: https://github.com/tractometry/pyAFQ/actions/runs/25732697842/job/75561654890