[ENH] Better consideration#189
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates core-relative streamline cleaning so numeric consideration thresholds fall back to closest-point evaluation when no streamline points fall within the threshold.
Changes:
- Documents the fallback behavior for float
consideration. - Extracts closest-point comparison into a helper.
- Uses that helper for both
"closest"mode and the numeric-threshold fallback.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
36000
force-pushed
the
fix_float_consideration
branch
from
May 16, 2026 05:21
fc0deed to
efcbbf4
Compare
Collaborator
Author
|
It worked, merging and releasing 3.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a problem @chiuhoward ran into. Let's wait to merge until we confirm it actually fixes it.