Skip to content

Conversation

@ldez
Copy link
Contributor

@ldez ldez commented Jun 24, 2019

What does this PR do?

Changes the loading resource order:

  • before: file > env > flags
  • after: file > flags > env

Related to #4985

Motivation

Kubernetes automatically creates a bunch of variables prefixed with TRAEFIK_ (probably based on the image name), and since our config loader was checking for the presence of the above prefix, this situation was obviously creating a conflict.

More

  • Added/updated tests
  • Added/updated documentation

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm :)

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit 4d44ab9 into traefik:v2.0 Jun 24, 2019
@ldez ldez deleted the fix/env-loading branch June 24, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants