-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Middlewares: add forwardAuth.authResponseHeadersRegex #7449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Middlewares: add forwardAuth.authResponseHeadersRegex #7449
Conversation
|
That's pretty strange for me why not related test has failed, maybe we should just trigger check again 🤔 |
|
Hi @iamolegga , Thanks for (re)opening the PR. 😉 |
rtribotte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @iamolegga,
Thanks for your work 👍
I have made several comments.
Also, could you:
- add the new field in the dynamic references in the doc contents (
file.toml,file.yml,marathon-labels.jsonanddocker-labels.yml) and generate afterward the KV references, trough ago generate? - add the new field to the middleware CRD ?
|
@rtribotte I've updated PR, I hope I didn't miss anything 😀 |
|
@rtribotte sorry for disturbing, is it correct now? |
|
Hello @iamolegga,
Don't hesitate if something is not clear ! ;-) |
|
@rtribotte thanks, finally understood what need to be done. updated 🙂 |
rtribotte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
jbdoumenjou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kevinpollet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Romain <rtribotte@users.noreply.github.com>
Co-authored-by: Romain <rtribotte@users.noreply.github.com>
Co-authored-by: Romain <rtribotte@users.noreply.github.com>
Co-authored-by: Romain <rtribotte@users.noreply.github.com>
What does this PR do?
adds new field
authResponseHeadersRegextoforwardAuthmiddlewareMotivation
fixes #6823
More
Additional Notes
update of outdated pr #6828