-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Add in flight connection middleware #8429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2dbef98 to
9cb604a
Compare
9cb604a to
6abfcdf
Compare
1f8dcd6 to
0186d6e
Compare
mpl
requested changes
Nov 29, 2021
mpl
requested changes
Nov 29, 2021
kevinpollet
reviewed
Nov 29, 2021
Co-authored-by: mpl <mathieu.lonjaret@gmail.com>
Co-authored-by: Kevin Pollet <pollet.kevin@gmail.com> Co-authored-by: mpl <mathieu.lonjaret@gmail.com>
d61d5c3 to
3d732cd
Compare
kevinpollet
reviewed
Nov 29, 2021
Co-authored-by: Kevin Pollet <pollet.kevin@gmail.com>
mpl
approved these changes
Nov 29, 2021
rtribotte
approved these changes
Nov 29, 2021
Member
rtribotte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
kevinpollet
approved these changes
Nov 29, 2021
Member
kevinpollet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a new TCP Middleware called InFlightConn.
This middleware does the same as the HTTP counterpart (i.e.
amount), except that you can't havesourceCriterionsince you have less metadata about a connection in TCP than in an HTTP request. Furthermore, the TCP connections are grouped by remote IP.Motivation
Solve half of #5999
More