Trailcode/compile fix#116
Merged
Merged
Conversation
The path was a gitlink (160000) in the index but .gitmodules had no entry for it (or was removed), causing: fatal: No url found for submodule path 'third_party/ImGuiColorTextEdit' in .gitmodules Replaced the submodule entry with the actual vendored source tree at the exact pinned commit (ca2f9f1462e3b60e56351bc466acda448c5ea50d) that the build system (CMake FetchContent fallback and third_party/README.md) expects. Now a regular directory with tracked files. Submodule commands no longer fatal, and the editor sources are present for offline builds. This matches the "prefer full checkout" guidance in the docs.
…ature "geometry" - vcpkg.json: replace boost[geometry] with "boost-geometry" (the actual port for <boost/geometry.hpp>). - CMakeLists.txt: guard find_package(Boost) and related so vcpkg toolchain case (CMAKE_TOOLCHAIN_FILE) skips it (headers come via toolchain include path). This resolves the "boost@1.91.0 does not have required feature geometry" error during vcpkg install in the Windows MSVC CI workflow. The no-as-needed for GLFW and nuget guards were already present from the windows build commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.