Hotkeys: reserve X/Y/Z, bindable keys, settings docs, reject toasts - #236
Merged
Conversation
added 2 commits
August 1, 2026 10:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_reserved_chord; drop on load).is_bindable_key; toast + inline message on unsupported, reserved, and conflict (including Reset).usage-settings.md#keyboard-shortcuts; Settings?links there.Closes #235
Test plan
?on Keyboard shortcuts opens settings guide (verbosity high enough)."X"binding — dropped on load.usage-settings.md#keyboard-shortcutsand links fromusage.md/ sketch hotkeys.Note
Low Risk
Localized to hotkey capture, load/save of
gui.hotkeys, and documentation; no changes to core modeling or auth paths.Overview
Tightens Settings → Keyboard shortcuts so remaps cannot break Move/Rotate or save unreadable chords.
Validation — Adds
is_bindable_key(letters, digits, Space, and named keys that round-trip in JSON); punctuation and numpad are rejected at capture, inset_chord, and when loadinggui.hotkeys. Unmodified X / Y / Z are now reserved inis_reserved_chordso axis constraints and rotation-axis pick stay available; invalid stored bindings are dropped on load.UX — Unsupported, reserved, and conflict outcomes (including per-row Reset) call
show_messagefor a status toast in addition to the inline table message. Settings adds a ? link (doc_urls::k_hotkeys) and updated help copy.Docs — New Keyboard shortcuts section in
usage-settings.md;usage.md/usage-sketch.mdpoint there;CHANGELOG.mdandsrc/doc/gui.mdupdated.Reviewed by Cursor Bugbot for commit e2cb60c. Bugbot is set up for automated code reviews on this repo. Configure here.