Shape local frame: axes / plane / up and face-based set - #252
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 432eae6. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
XYZframe UI: Shape List Show axes / Show plane / Show up, Reset frame to bbox, Set from planar/cylindrical face..., Flip up / Flip axis (Z).frameDisplaypersisted in.ezy.Mode::Shape_set_frame(Shape List only, no toolbar/hotkey); planar origin = face area centroid; cylindrical origin = solid center projected onto the axis; undo via frame-onlyShape_geom_delta.Test plan
EzyCad.ezykeepsframeDisplayflagsdocs/usage.md,src/doc/shape.md/gui.md, CHANGELOGCloses #251
Note
Medium Risk
New interactive mode, OCCT AIS lifecycle, and project JSON fields affect viewer stability and undo; scope is modeling UI rather than security-critical paths.
Overview
Adds Shape List workflows to view and edit each solid’s local
gp_Ax3frame: toggle Show axes / Show plane / Show up, Reset frame to bbox, Flip up / Flip axis (Z), and Set from planar/cylindrical face... (newMode::Shape_set_frame+Shp_set_frame, no toolbar hotkey).Shpnow builds optional AIS overlays (RGB triad, cyan plane, green up arrow), keeps them in sync with transforms and effective visibility (sketch modes, Hide all, hidden groups), and tears them down on remove/load/shutdown. Display toggles persist in.ezyasframeDisplay; frame edits use undoableOcct_view::set_shape_frame(Shape_geom_delta). Undo/redo mapsShape_set_frameback to Normal like other pick/drag tools.Reviewed by Cursor Bugbot for commit 7c045ac. Bugbot is set up for automated code reviews on this repo. Configure here.