Add bone sketch tool; extrude Both sides default; wasm CMake fixes - #256
Open
trailcode wants to merge 12 commits into
Open
Add bone sketch tool; extrude Both sides default; wasm CMake fixes#256trailcode wants to merge 12 commits into
trailcode wants to merge 12 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 61b156b. Configure here.
| X(Sketch_add_circle) \ | ||
| X(Sketch_add_circle_3_pts) \ | ||
| X(Sketch_add_slot) \ | ||
| X(Sketch_add_bone) /* two centers, then r1, r2, waist clicks */ \ |
There was a problem hiding this comment.
Saved mode values shift
Medium Severity
Sketch_add_bone is inserted in the middle of EZY_MODE_LIST, but projects store mode as that enum’s integer. Files saved before this change reopen Dimension, Cross-section, Align shafts, and Set frame as the next tool (Dimension becomes Add bone). mode.h already notes that reordering needs a migration.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 61b156b. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Shift+U/mode.add_bone): centers, radii, waist, optional holes and Bone A / Bone B nodes; commits outline then exits to Sketch inspectionFixes #255
Test plan
gui.bone_*)Shift+U/ remappablemode.add_bone; toolbar icon presentskt_testsif availableemcmakeprints* C++ compiler: EmscriptenandUsing FreeType (wasm); link succeeds (no-lfreetypeerror)Note
Medium Risk
New sketch geometry and undo paths add moderate complexity; wasm CMake changes affect all Emscripten link/configure flows but are localized to build scripts.
Overview
Adds an Add bone sketch workflow (Shift+U /
mode.add_bone): pick two centers, end radii, waist width, then optional holes. It builds a closed connecting-rod outline (tangent waist arcs), optional Bone A / Bone B center nodes, and returns to Sketch inspection after one commit instead of staying in the tool. Options Add center nodes and Holes persist asgui.bone_add_center_nodesandgui.bone_holes.Supporting changes include
Sketch::add_bone, bone geometry inutl_geom(make_bone_wire/compute_bone_geom),skt_tools_bone.cpp, sketch undo tweaks for promoted center nodes and names, and a documented Options layout (tool-specific block above Sketch options). Extrude sketch face now defaults Both sides to on for the session.Wasm builds detect Emscripten via
EMSCRIPTEN/CMAKE_SYSTEM_NAME(not onlyem++in the compiler path), resolve FreeType from the OCCT wasm install, and linkfreetypeso linking no longer fails on bare-lfreetype. Docs, changelog, icon, and default hotkeys/settings are updated accordingly.Reviewed by Cursor Bugbot for commit 61b156b. Bugbot is set up for automated code reviews on this repo. Configure here.