[pull] master from golang:master#16
Merged
pull[bot] merged 5 commits intotrailofbits:masterfrom May 6, 2026
Merged
Conversation
WARNING: This commit contains breaking changes. The `format` tag option is no longer supported by default. Similarly, the ability to use a single-quoted string for field names or for the `format` tag value is no longer supported by default. To enable both features, specify GOEXPERIMENT=jsonformat. Fixes #79071 Change-Id: I2cfdbd89dc84639e7423bee0e867d965d92a267b Reviewed-on: https://go-review.googlesource.com/c/go/+/773980 Reviewed-by: Michael Pratt <mpratt@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Damien Neil <dneil@google.com>
This brings in CL 773940, which should reduce flakes for HTTP/3 tests. For #79104 For #78737 Change-Id: I4875570b3a615faba0ea686a71621d4c6a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/774500 Reviewed-by: Nicholas Husin <husin@google.com> Reviewed-by: Damien Neil <dneil@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
…ak profile The main goroutine is no longer included in the goroutine leak profile if blocked at select without cases. The main goroutine is still treated as a leak during the analysis to avoid degrading analysis precision (see test), but has its status changed from leaked back to waiting before the profile is written. Based on feedback in #74609 (comment) Change-Id: I0fa2a93227006d99c2872c503a1eb67ad606a034 GitHub-Last-Rev: 84458d2 GitHub-Pull-Request: #78922 Reviewed-on: https://go-review.googlesource.com/c/go/+/770020 Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Auto-Submit: Keith Randall <khr@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
ScoreInductionInc was introduced in 19f0577. The goal was to keep the i++ in-place in a register. Placing ScoreInductionInc later than ScoreFlags further improves the generated code, mainly for code involving carry chains. For example, the math/big.addVW_ref inner loop was: LEAQ 1(CX), R8 ADDQ DX, R9 MOVQ R9, (AX)(CX*8) SBBQ R9, R9 NEGQ R9 MOVQ R8, CX After this commit: ADDQ DX, R9 MOVQ R9, (AX)(CX*8) SBBQ R9, R9 NEGQ R9 INCQ CX This is almost uniformly an improvement, across GOARCHes. There are a few functions where this perturbs regalloc and causes a little bit of movement, but they are rare and appear to be the usual uninteresting regalloc change noise. Change-Id: I883a92e4511136f478cf49471ba8b628434393dc Reviewed-on: https://go-review.googlesource.com/c/go/+/773660 Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Keith Randall <khr@golang.org> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Keith Randall <khr@golang.org>
CL 771782 introduced an extra index verification when reading in suffixarray indices. However, instead of testing against the overall suffixarray length, the condition checked against the (current) slice length which may be smaller than the indexarray length. This resulted in an error being reported when benchmarking a larger suffixarray that recorded its data using multiple data slices. The benchmark itself was not expecting an error and instead responded with a panic. Fix the condition by testing against the correct length. Also, adjust the testSaveRestore signature so we can pass in non-nil values so that the benchmark reports an error rather than panicking (before the bug fix). Fixes #79207. Change-Id: I523944ab1b133641e045a35435af6b6e2feed05d Reviewed-on: https://go-review.googlesource.com/c/go/+/774482 Reviewed-by: Robert Griesemer <gri@google.com> Reviewed-by: Keith Randall <khr@golang.org> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Robert Griesemer <gri@google.com> Reviewed-by: Keith Randall <khr@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )