[pull] master from golang:master#17
Merged
pull[bot] merged 1 commit intotrailofbits:masterfrom May 6, 2026
Merged
Conversation
… when retpoline The simd api translates non-constant inputs to instructions that require and immediate operand into switch tables. This occurs later in the pipeline than the retpoline guarded code that replaces table switches with binary search. Attempting to introduce Go simd code into the runtime triggered a test that checked for retpoline correctness and found this problem. The fix is to replace the table switch with a binary search where the intrinsic is inserted, if retpoline is active. This CL is adapted from part of a pending dev.simd CL for WASM support that also needs binary-search-switches. Change-Id: Ia9d38d09695307fa3955fe3d9348637935022278 Reviewed-on: https://go-review.googlesource.com/c/go/+/773900 Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Keith Randall <khr@golang.org> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )