[pull] master from golang:master#40
Merged
Merged
Conversation
This change simplifies go.mod files to have at most two require blocks (one for direct and one for indirect dependencies) when the go version is 1.27 or higher. Fixes #56471. Change-Id: I71bb41511575d02697945eb0fab787391018e652 Reviewed-on: https://go-review.googlesource.com/c/go/+/739061 Reviewed-by: Michael Matloob <matloob@golang.org> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
This is effectively a revert of CL 779221 which flipped the behavior of GOEXPERIMENT=genericmethods. It's much more natural to just flip the default for the experiment and keep everything else the same. We'll need to repeat CL 779221 when we go to turn down the experiment sometime before the release. For #77273 Change-Id: I18b6268c270451bee1ad3f20cbf92ca42170b032 Reviewed-on: https://go-review.googlesource.com/c/go/+/779301 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Robert Griesemer <gri@google.com>
In substituteWithBasicLit, set the position to the position of the literal we're replacing, so the new identifier has the correct position. This helps the formatter avoid breaking lines spuriously. For #79286 Change-Id: Ia5b0e6057b02430d247ba832e6619c806a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/777700 Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Michael Matloob <matloob@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
We disable sizespecializedmalloc if either raceenabled or valgrindenabled are true so this is dead code. For #79286 Change-Id: Ia1d7168b5c62e3f8f2dc2abd136774276a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/777800 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Matloob <matloob@google.com> Reviewed-by: Michael Pratt <mpratt@google.com>
This is purely refactoring that doesn't affect the generated code, other than adding some spurious blank lines that are more annoying to remove than to just deal with. For #79286 Change-Id: I363e44deb245139b531b9f69f52c0a206a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/777860 Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Michael Matloob <matloob@google.com> TryBot-Bypass: Michael Matloob <matloob@google.com>
Various tools assume that testdata directories are unnecessary if you don't need to run tests. This includes cmd/internal/bootstrap_test, which runs go install std on a GOROOT excluding testdata directories. Since this is an importable package rather than a test, to avoid breaking that case we must not actually name the directory testdata. We may want to reevaluate whether we want a dedicated package with embedded testdata at all, but for now the simple fix for the currently broken longtest builders is to simply rename the directory. For #71497. Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest Change-Id: Ic14ce7b06dca36cc758f99374da378c46a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/779302 Auto-Submit: Michael Pratt <mpratt@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> TryBot-Bypass: Michael Pratt <mpratt@google.com>
This makes it a little clearer that the work that happens after the allocation is duplicated in some cases. While it does produce some changes in the generated code, it should not affect the behavior or performance of the generated code. We should be able to remove the logic that checks for a terminating and non terminating return also after this. Change-Id: If01d45c08c88f9a8f1a9b0baa8c447ac6a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/779020 Reviewed-by: Michael Matloob <matloob@google.com> Reviewed-by: Michael Pratt <mpratt@google.com> Auto-Submit: Michael Matloob <matloob@golang.org> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
For fast computation of a string value's length w/o the need to first "materialize" the actual string. Use StringLen in the type checker where appropriate. Fixes #79042. Fixes #78346. Change-Id: Id602b060176b771d73fc737e0a37a9707f235a02 Reviewed-on: https://go-review.googlesource.com/c/go/+/772320 Auto-Submit: Robert Griesemer <gri@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Robert Griesemer <gri@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com>
Adds method Int.Divide to compute quotient and remainder of two Ints. Adds RoundingMode aliases Trunc, Floor, Round and Ceil. Fixes #76821 Change-Id: I7de80d76450f851d262b43a0685a0dc2218493f6 GitHub-Last-Rev: b52200b GitHub-Pull-Request: #76820 Reviewed-on: https://go-review.googlesource.com/c/go/+/729860 Reviewed-by: Robert Griesemer <gri@google.com> Reviewed-by: Damien Neil <dneil@google.com> TryBot-Bypass: Robert Griesemer <gri@google.com> Auto-Submit: Robert Griesemer <gri@google.com> Reviewed-by: Peter Weinberger <pjw@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )