Skip to content

Fix delete_schedule bug from smart scheduling change#164

Merged
naomiwise merged 2 commits into
mainfrom
fix-scheduling-bug
Jun 23, 2026
Merged

Fix delete_schedule bug from smart scheduling change#164
naomiwise merged 2 commits into
mainfrom
fix-scheduling-bug

Conversation

@naomiwise

@naomiwise naomiwise commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Context

Minor upgrade to fix bug when deleting a schedule. Bug got introduced in smart scheduling PR.

Checklist

Copilot AI review requested due to automatic review settings June 23, 2026 09:51
@naomiwise
naomiwise requested a review from a team as a code owner June 23, 2026 09:51
@platon-github-app-production

Copy link
Copy Markdown

Comment /request-review to automatically request reviews from the following teams:

You can also request review from a specific team by commenting /request-review team-name, or you can add a description with --notes "<message>"

💡 If you see something that doesn't look right, check the configuration guide.

@wise-github-bot-app

Copy link
Copy Markdown

This is currently a non-blocking check, and it will not prevent your Pull Request from being merged.

The CODEOWNER of this repository has some untagged assets.

As this is a public repository, asset details will not be shown.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Changes: Bugfix (1)

This PR fixes schedule deletion after the smart scheduling change by ensuring schedule backup cleanup targets schedule_id rather than being accidentally interpreted as snapshot_id.

Changes:

  • Update reset_schedule_backups invocation to pass schedule_id as a named argument.
  • Prevent erroneous deletion logic that could occur when the schedule ID is passed positionally.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wise-github-bot-app

Copy link
Copy Markdown

🟡

Approvals from users who have not completed the mandatory secure code training will be rejected in 13 day(s).

@naomiwise
naomiwise merged commit 97cb3ae into main Jun 23, 2026
5 of 8 checks passed
@naomiwise
naomiwise deleted the fix-scheduling-bug branch June 23, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants