feat(notations): deprecation policy names its removal release - #429
Merged
Conversation
CONTRACT.md §10.6 requires a status: deprecated spec to carry removed_in:, checked by the new DEP1 doc-lint rule. FGA (deprecated in 2.0.0, one-major window satisfied) is scheduled for removal in 4.0.0, with the migration recipe moved into migrations/3.1-to-4.0/ ahead of the actual cut. Signed-off-by: Valerii Korobeinikov <vkgeorgia@icloud.com> Signed-off-by: transitrix <279946036+transitrix@users.noreply.github.com>
…ecation-window Signed-off-by: transitrix <279946036+transitrix@users.noreply.github.com> # Conflicts: # scripts/check-notations.test.mjs
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONTRACT.md§10.6 states the deprecation policy: astatus: deprecatedspec must carryremoved_in:, the window is at least one MAJOR, removal is always a BREAKING changelog entry, and the migration recipe outlives the file it replaces.DEP1doc-lint rule (scripts/check-notations.mjs) enforces theremoved_in:requirement, with unit tests.2.0.0, one-major window satisfied) is scheduled for removal in4.0.0; its migration recipe moves intomigrations/3.1-to-4.0/ahead of the actual cut, per the policy's "recipe may land early" allowance. The spec itself is not deleted — removal happens at the major, not now.Test plan
node scripts/check-notations.mjs— cleannode --test scripts/check-notations.test.mjs— 8/8 passingmigrations/3.1-to-4.0/codemod.mjsagainstfixtures/before/, diffed output againstfixtures/after/— clean; verified idempotent (--dry-runsecond pass is a no-op)migrations/3.1-to-4.0/validate.mjsagainstfixtures/before/(fails, as expected) andfixtures/after/(passes)