ci: wire check-notations unit tests into the doc-lint workflow - #442
Merged
Conversation
The unit tests (scripts/check-notations.test.mjs) existed and passed locally but were never CI-wired — the earlier attempt was rejected server-side for lacking the workflow OAuth scope, resolved now.
Signed-off-by: transitrix <279946036+transitrix@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
scripts/check-notations.test.mjsunit tests to.github/workflows/notations-doc-lint.ymlas a step after the doc-lint check, so they run on every pull request and push tomain.Test plan
node scripts/check-notations.test.mjs— 18 checks passnode scripts/check-notations.mjs— doc-lint clean