Skip to content

Use sha384 signatures for list requests#42

Merged
tim-kos merged 4 commits into
mainfrom
fix/sha384-list-request-signatures
May 19, 2026
Merged

Use sha384 signatures for list requests#42
tim-kos merged 4 commits into
mainfrom
fix/sha384-list-request-signatures

Conversation

@tim-kos
Copy link
Copy Markdown
Member

@tim-kos tim-kos commented Apr 27, 2026

Summary

  • switch listRequest() signature generation from SHA-1 to SHA-384
  • include the sha384: algorithm prefix for list-request signatures
  • add regression tests for:
    • sign() uses sha384 with prefix
    • listRequest() uses sha384 with prefix

Why

api2 issue https://github.com/transloadit/api2/issues/5337 tracks SDK support for SHA-384 signatures.

The Go SDK already used SHA-384 for normal request signing, but listRequest() still used SHA-1 without a prefix. This made signature behavior inconsistent and could break accounts defaulting to SHA-384.

Notes

  • Smart CDN signing remains unchanged (SHA-256).

@kvz
Copy link
Copy Markdown
Member

kvz commented May 18, 2026

@tim-kos note that we at least need 256 for CDN support

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.60%. Comparing base (62a7440) to head (be28507).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   82.60%   82.60%           
=======================================
  Files           6        6           
  Lines         345      345           
=======================================
  Hits          285      285           
  Misses         32       32           
  Partials       28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tim-kos tim-kos merged commit 0e48c69 into main May 19, 2026
14 checks passed
@tim-kos tim-kos deleted the fix/sha384-list-request-signatures branch May 19, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants