Skip to content

companion,facebook: add support for facebook provider#1794

Merged
ifedapoolarewaju merged 2 commits into
masterfrom
facebook-provider
Sep 20, 2019
Merged

companion,facebook: add support for facebook provider#1794
ifedapoolarewaju merged 2 commits into
masterfrom
facebook-provider

Conversation

@ifedapoolarewaju
Copy link
Copy Markdown
Contributor

@ifedapoolarewaju ifedapoolarewaju commented Aug 22, 2019

No description provided.

@arturi
Copy link
Copy Markdown
Contributor

arturi commented Aug 26, 2019 •
edited
Loading

Very nice! 👍

Can we try switching to grid view? We might not support folders in it currently, need to prototype 🤔

@ifedapoolarewaju
Copy link
Copy Markdown
Contributor Author

ifedapoolarewaju commented Sep 14, 2019

Can we try switching to grid view? We might not support folders in it currently, need to prototype

@arturi as it might not be as straight forward, I created a separate task to do this. Is that fine? https://app.asana.com/0/707684331679643/1139911247489617/f

@goto-bus-stop
Copy link
Copy Markdown
Contributor

goto-bus-stop commented Sep 16, 2019 •
edited
Loading

What kind of app do I need to create to test this? 🤔

This needs "@uppy/facebook": "file:packages/@uppy/facebook" in the root package.json

Also needs its own facebook.md doc page as well for here:

image

@goto-bus-stop
Copy link
Copy Markdown
Contributor

goto-bus-stop commented Sep 16, 2019

OK, just a bare newly created FB App works and then copying ID / Secret from the Basic settings in the dev dashboard. Functionality wise looks good! 👍 just needs the few additional things mentioned above, I think.

@arturi
Copy link
Copy Markdown
Contributor

arturi commented Sep 18, 2019

Checked, works for me as well! Good to go once Renee’s comments are addressed, I think.

@ifedapoolarewaju ifedapoolarewaju merged commit 3fed571 into master Sep 20, 2019
@delete-merged-branch delete-merged-branch Bot deleted the facebook-provider branch September 20, 2019 10:00
@kvz kvz mentioned this pull request Sep 20, 2019
Closed
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
@ifedapoolarewaju
Merge pull request transloadit#1794 from transloadit/facebook-provider
8103fdf 
companion,facebook: add support for facebook provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goto-bus-stop goto-bus-stop Awaiting requested review from goto-bus-stop

@lakesare lakesare Awaiting requested review from lakesare

1 more reviewer

@arturi arturi arturi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ifedapoolarewaju @arturi @goto-bus-stop