Embedding lyrics in file metadata

[Batwam]

Hello,

My understanding is that LRCGET currently only allows to save the lyrics as .lrc files. Is there any plan to enable saving to the file metadata directly? Apologies if this has been discussed but I couldn't find any related discussion.

Some apps like Navidrome only recognise embedded lyrics and having the data in the file makes sure it remains accessible even if the file is renamed. While people can write scripts to load the lyrics into the metadata, it would be neat if LRCGET had an option to either save as lrc or save as metadata?

[tranxuanthang]

This is actually on my TODO list, I just haven't had enough effort to implement it yet. It is a bit more complicated than it looks. I need some time to research how to embed the lyrics into each kind of file formats.

Also, embedding lyrics into the music files means mutating it, meaning there is a chance that the software corrupts the music files. Since there are some people run LRCGET on their huge (and probably valuable) music collection, we must implement this carefully.

[VeksCZ]

I will be glad if it start by working with mp3s. :) I had multiple backups, so I will gladly test some nightly for you.

[Batwam]

I'm currently using beets for this as the lyrics.py plugin now allows LRCLIB. Not sure how they implemented it but it's working nicely, just in case you are looking for inspiration.

[Dylancyclone]

I've also written a plugin for MusicBrainz Picard that grabs lyrics from LRCLIB and embeds them

https://gist.github.com/Dylancyclone/72fdb3515ed6b4150365c46fe07f4de8

[Batwam]

By the way, if you are looking to implement this, I would recommend to keep embedding as an option as some apps like Plex don't currently recognise embedded lyrics so this method may not work for everyone.

[VeksCZ]

By the way, if you are looking to implement this, I would recommend to keep embedding as an option as some apps like Plex don't currently recognise embedded lyrics so this method may not work for everyone.

I have installed beet with lyrics plugin and I start to learn with that. I have created database. But I don't want to reorganize my library, just download .lrc & embed lyrics to mp3 tag. If I turn off copying whole library, lyrics plugin fetches lyrics but I can't see .lrc files anywhere nor lyrics embedded inside mp3 file itself. Can you help a little? Thank you.

[Batwam]

I'll respond on the part that's common for beets/lrcget as this is the lrcget repo so I'm assuming that you have all apps/plugins set up correctly. If not, I'd recommend posting on the beets issues tracker.

The issue could be that the lyrics don't exist in the database or the metadata isn't formatted properly. I'd recommend testing on a file you know has lyrics available from lrclib.net. If I remember correctly, the API requires not only the song/artist but also for the song duration to be close to the one in the database. Here is an example of a manual check you could do on LrcLib for Idioteque. Get the artist/album/track/duration for the mp3 you are testing with, update the url accordingly and see if it returns anything.

[tranxuanthang]

Good news here, the embedding lyrics feature has been added in this commit:

1ce9c7b

It works for both MP3 and FLAC files. I’ve tested it on my library and haven’t encountered any issues so far, but I’ll run some more tests before making a release.

[VeksCZ]

Good news here, the embedding lyrics feature has been added in this commit:

1ce9c7b

It works for both MP3 and FLAC files. I’ve tested it on my library and haven’t encountered any issues so far, but I’ll run some more tests before making a release.

So if I want to test it I should download .main branch and build it?.
Thanks.

[tranxuanthang]

@VeksCZ yeah, the feature is there in the main branch.

[VeksCZ]

Some info from testing:

==> Scanning tracks take: 6568ms
thread 'tokio-runtime-worker' panicked at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c\library\core\src\str\mod.rs:659:21:
byte index 30 is not a char boundary; it is inside 'á' (bytes 29..31) of Budu vechno co si bude prát
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

My testing library was stuck on 155/1821 tracks at first try. The second try:

Cannot parse the tag info from track: B:\Moje\Hudba\0 2 Oldies\9 9 Obřad\22 Tones & I - Dance Monkey (Street Violin Performance).mp3. Error: Encountered an invalid timestamp: Expected a separator
==> Scanning tracks take: 5957ms
thread 'tokio-runtime-worker' panicked at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c\library\core\src\str\mod.rs:659:21:
byte index 30 is not a char boundary; it is inside 'á' (bytes 29..31) of Budu vechno co si bude prát
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

I am from Czechia so we have a lot of unusual characters in track names.
Track artist and title are: Janek Ledecký - Budu všechno co si budeš přát

And one warning when building:
warning: profile package spec symphonia-format-wav in profile dev did not match any packages. Did you mean symphonia-format-caf?

I can see Unsynced lyrics tag inside mp3 at tracks where there were lyrics found and the .lrc file is present.
But what I would like to see lyrics inside Synced lyrics tag with timestamps. It is less useful than .lrc without that.

[tranxuanthang]

@VeksCZ Interesting, I will look into this bug as soon as I can.

I can see Unsynced lyrics tag inside mp3 at tracks where there were lyrics found and the .lrc file is present.
But what I would like to see lyrics inside Synced lyrics tag with timestamps. It is less useful than .lrc without that.

It does actually insert a SYLT tag (for synchronized lyrics) in MP3 files, you can test it with something like MusicBee in order to see it. I don't know why you don't see the SYLT tag, but keep in mind that SYLT tag is not very well supported among music players and tag editors (Mp3tag does not support reading SYLT tag, for example).

[tranxuanthang]

@VeksCZ,

thread 'tokio-runtime-worker' panicked at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c\library\core\src\str\mod.rs:659:21:
byte index 30 is not a char boundary; it is inside 'á' (bytes 29..31) of `Budu vechno co si bude prát`
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This is weird, I can't reproduce similar issue even with a similar track (title: Budu Všechno, Co Si Budeš Přát).

Can I ask which Rust version you used to compile the source code?

Also, can you try to build the 0.4.0 tagged commit (a6af3d7) to check if you face a similar error?

And did you see this error when scanning for tracks or when downloading all lyrics?

This is what I'm currently using to build LRCGET:

~/projects/lrcget on main [$!]
% rustup show
Default host: x86_64-unknown-linux-gnu
rustup home:  /home/thang/.rustup

stable-x86_64-unknown-linux-gnu (default)
rustc 1.78.0 (9b00956e5 2024-04-29)

[VeksCZ]

Maybe I am doing something wrong.
I am running on Windows 11 with Webstorm, via npm run tauri dev
rustc 1.81.0 (eeb90cda1 2024-09-04)

And it happens when I am downloading, scan is fine.