Skip to content

Conversation

@Luni-4
Copy link
Contributor

@Luni-4 Luni-4 commented Sep 17, 2021

Checklist:

  • All tests pass in CI.
  • The script/parse-examples passes without issues.
  • There are sufficient tests for the new fix/feature.
  • Grammar rules have not been renamed unless absolutely necessary.
  • The conflicts section hasn't grown too much.
  • The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

This PR updates tree-sitter-javascript to 0.20

@maxbrunsfeld

Can we release it on crates.io also? Thanks in advance! :)

@aryx
Copy link
Contributor

aryx commented Sep 17, 2021

@mjambon which version of tree-sitter are we using currently in ocaml-tree-sitter-semgrep?

@mjambon
Copy link
Contributor

mjambon commented Sep 21, 2021

What's the motivation for this change, @Luni-4 ? My understanding is that the version constraint ^0.19.0 allows tree-sitter 0.20.0, but ^0.20.0 doesn't allow tree-sitter 0.19.0.

@mjambon
Copy link
Contributor

mjambon commented Sep 21, 2021

I wrote:

My understanding is that the version constraint ^0.19.0 allows tree-sitter 0.20.0, but ^0.20.0 doesn't allow tree-sitter 0.19.0.

Sorry, I was wrong because 0. is not a real major version. https://github.com/npm/node-semver#caret-ranges-123-025-004

@mjambon mjambon merged commit c7dd612 into tree-sitter:master Sep 21, 2021
@Luni-4 Luni-4 deleted the update-0.20 branch September 21, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants