Skip to content

Conversation

@shcheklein
Copy link
Contributor

Followup treeverse/dvc#8542

Otherwise SVG is still not rendered.

@shcheklein shcheklein requested a review from daavoo November 20, 2022 01:07
@shcheklein
Copy link
Contributor Author

cc @blakeNaccarato FYI - if I'm not missing anything this is needed to properly support SVGs

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2022

Codecov Report

Base: 96.02% // Head: 96.02% // No change to project coverage 👍

Coverage data is based on head (18f14f8) compared to base (f783afc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   96.02%   96.02%           
=======================================
  Files          19       19           
  Lines         680      680           
  Branches      100      100           
=======================================
  Hits          653      653           
  Misses         22       22           
  Partials        5        5           
Impacted Files Coverage Δ
tests/test_image.py 100.00% <ø> (ø)
tests/test_vega.py 100.00% <ø> (ø)
src/dvc_render/image.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blakeNaccarato
Copy link

blakeNaccarato commented Nov 20, 2022

@shcheklein Thanks for pointing it out, and for wiring it up, as well.

Sorry, when I worked on the initial PR over at iterative/dvc, I didn't notice iterative/dvc-render and its role. I should have checked tests/integration/plots/test_plots.py and realized dvc-render's role in this. Thanks!

@daavoo
Copy link
Contributor

daavoo commented Nov 20, 2022

@shcheklein Thanks for pointing it out, and for wiring it up, as well.

Sorry, when I worked on the initial PR over at iterative/dvc, I didn't notice iterative/dvc-render and its role. I should have checked tests/integration/plots/test_plots.py and realized dvc-render's role in this. Thanks!

My bad for not raising this on the P.R. review 🙏

@daavoo daavoo merged commit 9757d86 into main Nov 20, 2022
@daavoo daavoo deleted the svg-support branch November 20, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants