Remove --all-commits options from usage output #2682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagunji
changed the title
efiop
suggested changes
Oct 28, 2019
dvc/command/gc.py
Outdated
Comment on lines
82
to
88
| # Issue number 2681 | ||
| # gc_parser.add_argument( | ||
| # "--all-commits", | ||
| # action="store_true", | ||
| # default=False, | ||
| # help="Keep data files for all commits.", | ||
| # ) |
Contributor
There was a problem hiding this comment.
Hi @sagunji !
Thanks for the PR!
The proper solution for this treeverse/dvc.org#730 (comment) is to hide this option like so:
gc_parser.add_argument(
"--all-commits",
action="store_true",
default=False,
help=argparse.SUPPRESS,
)
Contributor
Author
There was a problem hiding this comment.
Hi @efiop
I have pushed changes according to your request.
Thank you!
Contributor
Author
|
Thank you, my friend, @efiop 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you followed the guidelines in our
Contributing document?
Does your PR affect documented changes or does it add new functionality
that should be documented? If yes, have you created a PR for
dvc.org documenting it or at
least opened an issue for it? If so, please add a link to it.
Issue
Resolved #2681
Change
Commented out
--all-commitsoptional argument blockScreenshot