Remove multi-threaded prefix before progress bar(#2686) #2703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperdcl
reviewed
Oct 31, 2019
Contributor
|
How does it work? Do we have blank line now instead? |
Contributor
|
@Suor @kurianbenoy just updated this PR to "fix" (unfix) the issue. May have to revert at some point in the future if we start doing different things with nested multi-threaded bars but for now should be fine. |
Contributor
|
Just a reminder - adding other messages for commands should be separate issue(s). |
Suor
suggested changes
Nov 1, 2019
Contributor
Suor
left a comment
Suor
left a comment
There was a problem hiding this comment.
So how does it work now? Will progress bars be cleared properly without this?
casperdcl
approved these changes
Nov 2, 2019
Contributor
casperdcl
left a comment
casperdcl
left a comment
There was a problem hiding this comment.
ok killed off TqdmThreadPoolExecutor... ready for merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2686
Also change the import to follow PEP8 import rules
Have you followed the guidelines in our
Contributing document?
Does your PR affect documented changes or does it add new functionality
that should be documented? If yes, have you created a PR for
dvc.org documenting it or at
least opened an issue for it? If so, please add a link to it.