Skip to content

get-url: fix NPE when src non local and dst not absolute #2705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2019
Merged

get-url: fix NPE when src non local and dst not absolute #2705

merged 2 commits into from
Nov 1, 2019

Conversation

@shcheklein
Copy link
Contributor

@shcheklein shcheklein commented Oct 31, 2019

Fixes #2702

@shcheklein shcheklein requested review from a user and Suor October 31, 2019 17:00
Suor
Suor suggested changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@Suor Suor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good.

@shcheklein shcheklein requested a review from Suor November 1, 2019 16:52
ghost
ghost approved these changes Nov 1, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@efiop efiop merged commit ce8e019 into treeverse:master Nov 1, 2019
@weekly-digest weekly-digest bot mentioned this pull request Nov 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Suor Suor Suor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Problems when downloading file from s3

3 participants

@shcheklein @Suor @efiop