Skip to content

get/import: more meaningful message on NoRemoteError #2759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2019
Merged

get/import: more meaningful message on NoRemoteError #2759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
deba7e9
get/import: more meaningful message on NoRemoteError
pared Nov 8, 2019
76fb661
get/import: handle NoRepoError with external_repo
pared Nov 12, 2019
48d16f6
Update dvc/exceptions.py
pared Nov 12, 2019
4a6a1b6
Update dvc/external_repo.py
pared Nov 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions dvc/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,3 +328,13 @@ def __init__(self, target_infos):

class CollectCacheError(DvcException):
pass


class RemoteNotSpecifiedInExternalRepoError(DvcException):
def __init__(self, url, cause=None):
super(RemoteNotSpecifiedInExternalRepoError, self).__init__(
"No DVC remote is specified in the target repository '{}'".format(
url
),
cause=cause,
)
7 changes: 6 additions & 1 deletion dvc/external_repo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

from funcy import retry

from dvc.config import NoRemoteError
from dvc.exceptions import RemoteNotSpecifiedInExternalRepoError
from dvc.utils import remove


Expand All @@ -19,7 +21,10 @@ def external_repo(url=None, rev=None, rev_lock=None, cache_dir=None):

path = _external_repo(url=url, rev=rev_lock or rev, cache_dir=cache_dir)
repo = Repo(path)
yield repo
try:
yield repo
except NoRemoteError as exc:
raise RemoteNotSpecifiedInExternalRepoError(url, cause=exc)
repo.close()


Expand Down