Skip to content

Conversation

@pared
Copy link
Contributor

@pared pared commented Nov 8, 2019

  • ❗ Have you followed the guidelines in the Contributing to DVC list?

  • πŸ“– Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.

  • ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addresses. Please review them carefully and fix those that actually improve code or fix bugs.

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Fixes #2711

@shcheklein
Copy link
Contributor

We have already a message that starts with Setup default remote with ... - do we keep it? @pared could you please show screens of how would it look like so that we can review?

@pared
Copy link
Contributor Author

pared commented Nov 11, 2019

@shcheklein

We have already a message that starts with Setup default remote with ... - do we keep it? @pared could you please show screens of how would it look like so that we can review?

I don't think we should remove this message, as NoRemoteError can be raised when trying to push/pull/fetch. I would rather consider newly added error as "interpretation" of NoRemoteError which has meaning only in case of get/import.

Reproduction script:

#!/bin/bash

rm -rf repo remote_repo storage git_repo
mkdir repo remote_repo storage git_repo

pushd remote_repo
git init >> /dev/null && dvc init -q

set -x
set -e
echo data >> data
dvc add data
git add .dvc/config data.dvc .gitignore
git commit -m "add data"

popd
pushd repo

git init >> /dev/null && dvc init -q
dvc import ../remote_repo data

Result:
https://asciinema.org/a/280490

Co-Authored-By: Ruslan Kuprieiev <kupruser@gmail.com>
Co-Authored-By: Ruslan Kuprieiev <kupruser@gmail.com>
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@efiop efiop merged commit c1bbd8d into treeverse:master Nov 13, 2019
@pared pared deleted the 2711 branch December 17, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get/import: improve error message on no default remote

4 participants